make redis schedule read an atomic pop operation via eval #107
Conversation
72squared
force-pushed
the
schedule_read_fix
branch
from
ddeda2f
to
b89ed21
Compare
|
Cool, is there any way you could modify this to use the |
|
I imagine the script could be registered in the |
72squared
force-pushed
the
schedule_read_fix
branch
from
b89ed21
to
4d748f7
Compare
|
I made the suggested changes, squashing everything into one commit. Anything else? |
| local res = redis.call('zrangebyscore', key, '-inf', unix_ts) | ||
| if #res and redis.call('zremrangebyscore', key, '-inf', unix_ts) == #res then | ||
| return res | ||
| end |
There was a problem hiding this comment.
Why is it necessary to check the return value here of zremrangebyscore?
There was a problem hiding this comment.
that gives you the count of the elements it removed from the sorted set. If the count doesn't match up with the number you intended, that means it wasn't able to remove those elements from the sorted set and you don't want to return those elements from the list to be worked on. It will almost never happen since redis will be working inside that single thread to do that operation atomically but still it's not a bad practice to checksum it and it won't introduce any latency.
There was a problem hiding this comment.
FYI, I've been using this patch on my dev server for the past week and everything is working flawlessly.
make redis schedule read an atomic pop operation via eval
|
Thanks so much for making this happen! |
This is the patch we discussed to address issue #105