Fix inconsistencies with date fields

[jitendrapurohit]

Overview

Fix issues with date fields.

Before

Issue 1: Custom date field is not loaded as default when the format is year only. To replicate

• Create a custom date field with format = yearonly
• Enable this on the webform.
• Since this is a yearonly field, change the type of this element from the build page.

Type: Date list

• Make sure a contact A in civi is holding a value for this field.
• Load the webform with c1 = A loaded by default. i.e cid1=xx in the url.
• The year only date field is not loaded with the existing value from CiviCRM.

Issue 2: Same webform:

• Remove the default setting from existing contact element and change the widget to Autocomplete.
• Load the webform and select a contact from autocomplete contact field.
• The year value is not retrieved.

Issue 3: Same webform.

• Enter a default value of the year only date field to today.

• Edit Existing contact element: make sure the custom field is select to no autofill.

• Load the webform and ensure the date field value is set correctly before and after selecting a contact. i.e, it should stay as today's year.

After

Fixed. All 3 cases work as expected.

[mpaulso]

Before the PR

[mpaulso]

After PR

[mpaulso]

Passing in cid1

[mpaulso]

changing to autocomplete - please note -> YEAR is not loaded

[KarinG]

So from our testing summary:

• current user ✅ shows Year
• ?cid = ✅ shows Year
• autocomplete [changed widget static->autocomplete + deselect "Use contact id from UR"L checkbox] does not show Year

[jitendrapurohit]

autocomplete [changed widget static->autocomplete + deselect "Use contact id from UR"L checkbox] does not show Year

Seems similar to this issue fixed here https://github.com/colemanw/webform_civicrm/pull/666/files. I've included the loading of date fields in that PR.

[KarinG]

After PR 666 -> this is now working 🎉 ->

[KarinG]

Automated tests ✅
Live site check ✅
Screenshot (above)