-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for custom default fuction with owned pattern #315
Open
Wasabi375
wants to merge
12
commits into
colin-kiegel:master
Choose a base branch
from
Wasabi375:owned_custom_default
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Mar 23, 2024
-
Base impl for custom defaults in owned pattern
There are still a lot of tests failing, but my usecase works. Now I just have to fix all the corner cases. Also tests for the new feature are still missing.
Configuration menu - View commit details
-
Copy full SHA for ee522ae - Browse repository at this point
Copy the full SHA ee522aeView commit details -
Fix all tests/examples in derive_builder package
this still leaves tests in all other packages including tests for internals in derive_builder_core
Configuration menu - View commit details
-
Copy full SHA for 7161d93 - Browse repository at this point
Copy the full SHA 7161d93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97a6cab - Browse repository at this point
Copy the full SHA 97a6cabView commit details -
Configuration menu - View commit details
-
Copy full SHA for 09bcb83 - Browse repository at this point
Copy the full SHA 09bcb83View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c4b118 - Browse repository at this point
Copy the full SHA 1c4b118View commit details
Commits on Mar 24, 2024
-
turns out having a todo in the test data generation is not good if you want the tests to pass :)
Configuration menu - View commit details
-
Copy full SHA for bfbfe5b - Browse repository at this point
Copy the full SHA bfbfe5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7729bb9 - Browse repository at this point
Copy the full SHA 7729bb9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad622f8 - Browse repository at this point
Copy the full SHA ad622f8View commit details -
remove conversion from field_default_value + docs
conversion is only used to disable the default value if the enum is not OptionOrDefault. It's cleaner to just use an enabled flag for that.
Configuration menu - View commit details
-
Copy full SHA for 0b75a7f - Browse repository at this point
Copy the full SHA 0b75a7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c342aba - Browse repository at this point
Copy the full SHA c342abaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 33b1a45 - Browse repository at this point
Copy the full SHA 33b1a45View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2510cf - Browse repository at this point
Copy the full SHA c2510cfView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.