Skip to content

Commit

Permalink
Reducing required flags
Browse files Browse the repository at this point in the history
Following the WoW client’s lead - going to allow files to inherit owner of the user running the application - but the file permissions should be maintained. Could manually 777 everything - but for now we’ll let the tarfile set that.

Technically this could cause issues as the permissions of what the installer wrote and what is on disk may diverge - but that won’t effect functionality - only “repair permissions” scans.
  • Loading branch information
colincornaby committed Jun 17, 2024
1 parent 5d111b9 commit d36917d
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions Sources/Plasma/Apps/plClient/Mac-Cocoa/PLSPatcher.mm
Original file line number Diff line number Diff line change
Expand Up @@ -232,10 +232,6 @@ static la_ssize_t copy_data(struct archive *ar, struct archive *aw)

/* Select which attributes we want to restore. */
flags = ARCHIVE_EXTRACT_TIME;
flags |= ARCHIVE_EXTRACT_ACL;
flags |= ARCHIVE_EXTRACT_FFLAGS;
flags |= ARCHIVE_EXTRACT_OWNER;
flags |= ARCHIVE_EXTRACT_XATTR;

struct archive *a = archive_read_new();
struct archive *ext = archive_write_disk_new();
Expand Down

0 comments on commit d36917d

Please sign in to comment.