handle decimal values correctly

colinmarc · Sep 4, 2014 · 10cc573 · 10cc573
1 parent 177c9a4
commit 10cc573
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/lib/impala/cursor.rb b/lib/impala/cursor.rb
@@ -129,7 +129,7 @@ def convert_raw_value(value, schema)
         end
       when 'tinyint', 'smallint', 'int', 'bigint'
         value.to_i
-      when 'double', 'float'
+      when 'double', 'float', 'decimal'
         value.to_f
       when "timestamp"
         Time.parse(value)

diff --git a/test/test_impala_connected.rb b/test/test_impala_connected.rb
@@ -55,7 +55,7 @@ def connect
     end
 
     it 'can handle double values' do
-      ret = @connection.query('SELECT 1.23 AS foo')
+      ret = @connection.query('SELECT CAST(1.23 AS double) AS foo')
       assert_equal([{:foo=>1.23}], ret, "the result should be a float")
     end
 
@@ -69,6 +69,11 @@ def connect
       assert_instance_of(Float, ret.first[:foo], "the result should be a float")
     end
 
+    it 'can handle decimal values' do
+      ret = @connection.query('SELECT CAST(1.5 AS decimal(9,4)) as foo')
+      assert_instance_of(Float, ret.first[:foo], "the result should be a float")
+    end
+
     it 'can handle timestamp values' do
       ret = @connection.query('SELECT NOW() AS foo')
       assert_instance_of(Time, ret.first[:foo], "the result should be a timestamp")