Revert the array constant, use the private static array again. This d…

[aaajeetee]

…oes not break the PHP 5.4 and 5.5 compatibility

[Xon]

@aaajeetee you might as well preserve the O(1) lookup behaviour instead of the in_array linear search behaviour.

The test matrix only went as far back as php 5.6 (which is the last 5.x version which is not yet EOL), as such the automatic testing didn't catch this.

[colinmollenhour]

@aaajeetee you might as well preserve the O(1) lookup behaviour instead of the in_array linear search behaviour.

Agreed, in_array is not efficient for something which will conceivably be used many many times. It might be a speculative micro-optimization but it is already there, just use a private static array as a hash with isset(). An optimized preg_match might be the fastest but would sacrifice code maintainability.

[aaajeetee]

Thanks for the feedback. I have used the array_key_exists() function call now, as it is in version 1.9.0.

[aaajeetee]

Also, is it an idea to update the travis file to also test PHP versions 5.4 and 5.5?

[colinmollenhour]

I added PHP 5.5 to the unit tests and got it passing. Is there a real use-case for officially supporting PHP 5.4? It actually passes currently but the number of places it is supported is dwindling..

https://travis-ci.org/colinmollenhour/credis/builds/283894536

[aaajeetee]

There isn't really a use-case for supporting PHP 5.4 I suppose, it's more the fact that this project supports PHP 5.4, so might as well test it.

But in the end that's your decision.