Stop screensharing on microphone permissions error in AUDIO_SCREEN mode #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thijstriemstra
requested changes
Jun 9, 2021
There was a problem hiding this comment.
thanks @RomanMukhin
does this happen in other screen sharing modes as well?
can you also add a changelog entry?
RomanMukhin
force-pushed
the
stop-screen-sharing-on-microphone-permissions-error-in-audio-screen-mode
branch
from
845dcfa
to
4fb6f64
Compare
|
@thijstriemstra added entry to changelog. This happens only in AUDIO_SCREEN since it's the only place where navigator.mediaDevices.getDisplayMedia promise is chained with navigator.mediaDevices.getUserMedia promise |
RomanMukhin
force-pushed
the
stop-screen-sharing-on-microphone-permissions-error-in-audio-screen-mode
branch
from
4fb6f64
to
d533d94
Compare
RomanMukhin
force-pushed
the
stop-screen-sharing-on-microphone-permissions-error-in-audio-screen-mode
branch
from
d533d94
to
7c6218b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHEN the AUDIO_SCREEN mode is selected
AND screen sharing is allowed
AND microphone is NOT allowed
THEN screen sharing continues despite the fact that "device error" event is triggered (not "device ready")
Expected: screen sharing stream is closed and the device error event is triggered