Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: part or all actions-rs unmaintained #56

Closed
Razaloc opened this issue Nov 30, 2022 · 4 comments
Closed

CI: part or all actions-rs unmaintained #56

Razaloc opened this issue Nov 30, 2022 · 4 comments

Comments

@Razaloc
Copy link
Contributor

Razaloc commented Nov 30, 2022

actions-rs/toolchain seems to be unmaintained. Something similar with actions-rs/cargo We use it and at some point part of it will be deprecated; we need to make it compatible with Node.js 16. CI raise this warning:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions-rs/toolchain@v1, actions-rs/cargo@v1

Also:
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Razaloc added a commit that referenced this issue Dec 1, 2022
actions-rs/cargo erased
actions-rs/toochain replaced by dtolnay/rust-toolchain@master
Closes: #56

Signed-off-by: Rafael Garcia Ruiz <rafael.garcia@collabora.com>
Razaloc added a commit that referenced this issue Dec 3, 2022
actions-rs/cargo erased
actions-rs/toochain replaced by dtolnay/rust-toolchain@master
Closes: #56

Signed-off-by: Rafael Garcia Ruiz <rafael.garcia@collabora.com>
Razaloc added a commit that referenced this issue Dec 4, 2022
actions-rs/cargo erased
actions-rs/toochain replaced by dtolnay/rust-toolchain@master
Closes: #56

Signed-off-by: Rafael Garcia Ruiz <rafael.garcia@collabora.com>
@Razaloc
Copy link
Contributor Author

Razaloc commented Dec 4, 2022

This issue might be relevant for other projects, also using actions-rs/toolchain and actions-rs/cargo:
lava-api
lava-gitlab-runner
gitlab-runner-rs
obs-gitlab-runner
open-build-service-rs
hawkbit-rs
If this patch turns out to solve the problem I could apply the same solution to the others

Razaloc added a commit that referenced this issue Dec 6, 2022
actions-rs/cargo in unmaintained.
It uses Node.js 12 actions, which are deprecated.
It raises warnings at all tests.
We are replacing it and just calling cargo at "run" statements
Closes: #56

Signed-off-by: Rafael Garcia Ruiz <rafael.garcia@collabora.com>
Razaloc added a commit that referenced this issue Dec 16, 2022
actions-rs/cargo in unmaintained.
It uses Node.js 12 actions, which are deprecated.
It raises warnings at all tests.
We are replacing it and just calling cargo at "run" statements
Closes: #56

Signed-off-by: Rafael Garcia Ruiz <rafael.garcia@collabora.com>
@Razaloc
Copy link
Contributor Author

Razaloc commented Dec 21, 2022

Version 1.1.0 uses Node16 (instead of Node12)
Update the action to run on Node 16
This two PRs should solve the warnings, in that case we wouldn't need #57

@obbardc
Copy link
Collaborator

obbardc commented Jan 12, 2024

This is covered at actions-rs/toolchain#216 ; I have subscribed to that.

@sjoerdsimons
Copy link
Contributor

fwiw for my other crates i've moved to https://github.com/dtolnay/rust-toolchain

sjoerdsimons added a commit that referenced this issue Feb 24, 2024
actions-rs is deprecated, move to dtolnay/rust-toolchain instead.

Fixes: #56

Signed-off-by: Sjoerd Simons <sjoerd@collabora.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants