Statsd port inuse #1133
Closed
Statsd port inuse #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/proc/pid/status instead of counter the number of files in /proc/pid/task/*.
if it doesn't start with "Vm" and it doesn't start "Threads".
collectd.service superseded by systemd.collectd.service
…llback. Should reading the number of threads from /prod/$pid/status fail, use the number provided by /prod/$pid/stat as a fallback. If that fails, too, use 1. As discussed with @manuelluis in collectd#1033.
Also fixes an off-by-one error in counter_diff() and adds a unit test for the function.
Passing in "value" as a derive_t and returning the rate as a value_t is just inconvenient and wrong. Instead, pass "value" as a value_t and return the rate in a gauge_t. While at it, move the state pointer to the end of the argument list.
Hopefully fixes "Uninitialized argument value" warning.
The previous implementation broke when off1 / off2 were outside of "string" but within "buflen". It also had problems if the replacement string was too long. This new implementation truncates the buffer as expected and is properly tested.
This fix is likely incomplete: the printf() line is probably executed way too often now.
Also fixes a shadowed local variable warning.
Apparently defining this in the source files confuses Solaris' libc. Thanks to @dago for looking into this. Hopefully fixes: collectd#978
…standards in configure.ac. Fixes: collectd#978
This broke the build under Solaris, once again *sigh*.
collectd-tg.c: In function ‘dtime’:
collectd-tg.c:108:12: error: ‘NAN’ undeclared (first use in this function)
return NAN;
^
There's a signed / unsigned conversion in that function ... ... aaaaand it's fully rewritten. Oops.
serial.c:87:28: error: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Werror,-Wshorten-64-to-32]
len = strlen (fields[0]) - 1;
~ ~~~~~~~~~~~~~~~~~~~^~~
serial.c:96:10: error: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Werror,-Wshorten-64-to-32]
len = strlen (fields[i]);
~ ^~~~~~~~~~~~~~~~~~
Document the use of "Linux abstract namespace sockets" and use sendto(2) instead of sendmsg(2) to avoid having to initialize struct msghdr and struct iovec. Removes the non-portable bzero() calls.
Also re-indent oconfig_clone().
* The tests for common and meta_data logged "not ok" but didn't signal failure because OK1() didn't include a return(-1) line. Adding this line caused some restructuring of the utils_vl_lookup test, because it used that macro in non-int functions. * Fix DBLEQ() to work correctly with an expected NaN. Previously, the if condition would fall through to the "expect != actual" part, which is true for "NaN != NaN". * Let the mock cdtime() return a non-zero value, as the (invalid) zero value is used in parse_values() to detect whether the time has been parsed already. This lead to the "N:..." tests failing. * Correct the expected behavior of meta_data_add_*() when keys already exist: they're replaced rather than causing an error.
|
@michaelsalmon thanks for your patch ! It looks like something went wrong with the pull-request though: Commits 112 Files changed 93 Could you please rebase your patchset against the collectd-5.4 branch, and resubmit against this branch please ? Thanks ! |
|
I have created a new pull request that only changes 1 file this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch primarily fixes the error that is sent if getaddrinfo returns both the IPv4 & IPv6 wildcard address. If a bind has been successful then the error is downgraded to an info. The only case that I can think of where this will occur is just multiple wildcards.
It also removes the call to getnameinfo if debug is not enabled and does not add AI_ADDRCONFIG to hints if there won't be any DNS lookup.