Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connectivity plugin #2407

Closed
wants to merge 28 commits into from
Closed

Connectivity plugin #2407

wants to merge 28 commits into from

Conversation

abays
Copy link
Contributor

@abays abays commented Aug 21, 2017

Red Hat NFVPE network interface status monitoring plugin

@rpv-tomsk
Copy link
Contributor

Hi!

Please review a set of files of your PR. There is a new file clean which should not be merged, IMHO.

Also, there is two files with plugin documentation: src/collectd-connectivity.pod and src/collectd.conf.pod. I think, the first one also should not be merged. (And it's content has some typos).

Can you please say some words about this plugin, what info it provides? Only interface status (up/down)?
I see, it has many 'meta' submitted. Can you please share your experience, how do you use that?

Thanks!

@rpv-tomsk
Copy link
Contributor

Sorry for a dumb question, what is the 'NFVPE'?

@octo
Copy link
Member

octo commented Oct 11, 2017

Hi @abays,

thank you very much for your PR! I think this functionality could quite easily be added to the existing netlink plugin which already implements dealing with netlink sockets, avoiding a big amount of overhead.

Best regards,
—octo

@abays
Copy link
Contributor Author

abays commented Nov 6, 2017

Hello all! We've created a Google doc in an attempt to explain why we created a separate plugin as opposed to trying to merge the functionality into the existing netlink plugin. Please see the link below. Thank you.

https://docs.google.com/document/d/1dmz6TV-Tq0zVrtC1c5-De6GbgFT2yDxMt35QuDuo7g4/edit?usp=sharing

@abays
Copy link
Contributor Author

abays commented Dec 13, 2017

Cleaning and re-requesting

@abays abays closed this Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants