Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Df metadata for plugin instance #2567

Closed
wants to merge 3 commits into from
Closed

Df metadata for plugin instance #2567

wants to merge 3 commits into from

Conversation

vtols
Copy link

@vtols vtols commented Nov 21, 2017

This pull request adds original plugin instance to value list meta of df plugin. This is done because after replacing / with - (and also root) reconstructing original plugin instance is ambiguous. With this change it would be possible to fetch the original name from metadata

Add unescaped plugin instance (disk name) string to value list meta
@rmakulov rmakulov mentioned this pull request Nov 21, 2017
@rpv-tomsk
Copy link
Contributor

Such a solution will not work when 'hub' topology (with Collectd-agents which send metrics to a central Collectd-hub) is used. Metadata is not sent over network.

# Conflicts:
#	src/df.c
@vtols
Copy link
Author

vtols commented Feb 26, 2018

@rpv-tomsk, yes we know about the problem. At this moment we have these options:

  1. Discard the changes, original path metadata won't be added.
  2. Leave things as is, metadata is available only for local collectd plugins, and is not sent over network.
  3. Make changes allowing network plugin to send metadata over network.

Have you any suggestions?

@vtols vtols closed this Oct 15, 2019
@faxm0dem
Copy link
Contributor

Hi,
It's unfortunate this got closed.
I believe it was a good idea, and as a user of write_riemann, I would definitely have use of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants