lua: fix lua registration callback for more then one lua script #3139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now it was not possible to register more than one lua script. With this change it is now possible. Signed-off-by: Florian Eckert <fe@dev.tdt.de>
feckert
changed the title
|
@octo ping |
rpv-tomsk
added a commit
to rpv-tomsk/collectd
that referenced
this pull request
May 1, 2019
lua_tostring(), used to identify readers/writers, doesn't work on functions (it returns NULL). So, callback name is not unique and its registration fail. Added code to store script path and callback index in LUA Registry and to build callback name based on them. Added possibility to pass LUA callback as global-scope function name. In this case callback name is built using function name, not callback index. Closes: collectd#2379 Closes: collectd#3139
This was referenced May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already applied to NetBSD:
http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/sysutils/collectd/patches/patch-src_lua.c?annotate=1.1
Closes #2379
Changelog: lua: fix lua registration callback for more then one lua script