[collectd 6] Introduce a floating point counter type. #4266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octo
force-pushed
the
6/fpcounter
branch
2 times, most recently
from
9b5ded8
to
355f01b
Compare
eero-t
reviewed
Jan 31, 2024
Some compilers don't like empty statements, e.g.:
```
src/utils/format_kairosdb/format_kairosdb.c:122:8: error: label at end of compound statement
122 | case METRIC_TYPE_UNTYPED:
| ^~~~~~~~~~~~~~~~~~~
```
eero-t
reviewed
Jan 31, 2024
…h statement. This way the compiler can check that we handle all values in the `metric_type_t` enum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is a super-set of #4265, which should be merged first.
This change introduces a new metric type, called "FPCOUNTER". This is useful when the resolution provided by integers is not sufficient. A good example is the
system.cpu.timemetric, which should be measured in seconds. However, with a ten second interval, the counters of all states combined will only increase by ten, resulting in very poor resolution.One difference to integer counters is that floating point counters don't overflow. We therefore treat every situation in which the previous value is larger than the current value as a counter reset.
ChangeLog: Daemon: The new
FPCOUNTER(floating point counter) metric type has been added.