[collectd 6] Scale time metrics to seconds per second using floating point counters. #4272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to `rate_to_value()` and `value_to_rate()`.
eero-t
reviewed
Feb 12, 2024
| &fam_ops_time, direction_label, write_direction, | ||
| (value_t){.derive = (derive_t)(write_time_s * 1000000.0)}, &m); | ||
| metric_family_append(&fam_ops_time, direction_label, read_direction, | ||
| (value_t){.fpcounter = (fpcounter_t)read_time_s}, |
There was a problem hiding this comment.
Macro could have made lines like these nicer.
Comment on lines
+524
to
+533
| .v0 = {.counter = 4294967238ULL}, | ||
| .v1 = {.counter = 42}, | ||
| .want = 10.0, | ||
| }, | ||
| { | ||
| .name = "counter_t 64bit wrap-around", | ||
| .t0 = 30, | ||
| .t1 = 40, | ||
| .type = METRIC_TYPE_COUNTER, | ||
| .v0 = {.counter = 18446744073709551558ULL}, |
There was a problem hiding this comment.
Wrap-around initial values would IMHO be clearer as 0xffffffff-57 and 0xffffffffffffffff-57.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts the following metrics to seconds per second, in order to align with OpenTelemetry Semantic Conventions:
system.cpu.time(link)system.disk.operation_time(link)system.disk.io_time(link)system.disk.weighted_io_timeThe CPU plugin relies on
rate_to_value()andvalue_to_rate(), which were lacking support for floating point counters still. Apparently I missed them in #4266. This PR fixes them.ChangeLog: CPU and Disk plugins: Time metrics have been changed to report seconds per second.