Correct feed-folder list, solve datetime keyerror and update beautifulsoup #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jbofill
commented
Nov 21, 2013
jbofill
commented
- Correct feed-folder.html so it lists feed item's summary, not the body.
- Solve datetime KeyError: u'+0000. due to GMT not especified (see second error in issue Index gets an invalid date when feedItemUpdated date set to October 31 #7). Test example: http://planet.python.org/rss20.xml always has Thu, 14 Nov 2013 22:57:42 +0000. The error appears when you restart your instance.
- Update to beautifulsoup4 and use python's built-in HTML parser (solved errors I hit when the feed had some escape characters in it, but unable to reproduce).
…xample: http://planet.python.org/rss20.xml <pubDate>Thu, 14 Nov 2013 22:57:42 +0000</pubDate>
| "getFeedItemUpdated" : date_range_query, | ||
| "sort_on" : "getFeedItemUpdated" | ||
| }) | ||
| items = list(items) |
There was a problem hiding this comment.
This line seems unneeded. The for b in items in the next line should work just fine on its own.
|
Thanks for the pull request. Sorry for being late in picking this up. I will consider merging it. But as you see, I have added some remarks, so please have a look at those. Also, please add something to the changelog and add a few lines about the megaclean feature to the readme. |
mauritsvanrees
added a commit
that referenced
this pull request
Jan 17, 2014
Correct feed-folder list, solve datetime keyerror and update beautifulsoup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.