Ckeditor 4.4.8 and a builder for next releases #44
Conversation
|
Hi @gotcha I tested a little and it seems that some plugins are missing, if I activate every buttons, some do not show like :
Maybe is it no more builtin now? +++ Gauthier |
|
Yup, scayt has disappeared from https://github.com/ckeditor/ckeditor-dev/tree/release/4.4.x/plugins I should have checked the differences with @gbastien can you extend https://github.com/collective/collective.ckeditor/tree/builder/dev/build-ckeditor to add the missing plugins ? |
|
Hi @gotcha actually I prefer you adapt the script ;-), I do not want to spend to much time discovering what it does. What I just wanted to underline is that full presets release are left available, for example : http://download.cksource.com/CKEditor/CKEditor/CKEditor%204.4.8/ckeditor_4.4.8_full.zip This way you are sure to get the right full preset, it can evolve (http://ckeditor.com/presets). Then the builder script could "just" take care to grab extra plugins (or we can do it manually double-checking version compatibility). We need to check the _full preset, especially regarding the default selected skin that seems to be "Moono" instead of "Moono color"... So :
? |
|
I'll look at this when I'll have time. |
|
Hi @gotcha to me a "manual recipe" is not a problem, PR review will cover this. Downloading the full release will make sure we have relevant things and not create our builder script (if I look here, I do not want : https://github.com/ckeditor/ckeditor-dev/blob/master/dev/builder/build.sh). We may write a script just receiving the CKEditor version we want and :
We may work on this too if you are ok with this approach. Gauthier |
|
The approach I took is to use ckbuilder from the ckeditor team: The problem I have with doing clicks is that it is too easy to forget steps. For instance, I had forgotten By scripting the release, we will be able to get the fixes from ckeditor quicker as well. |
|
I am ok to script, but what I propose is to use the release the CKEditor team builds because we do not know what could change in the future... Script the fact to get the release, "sed" it to "Moono color", script the the fact to get plugins and to merge it in the release, ... But maybe not write yet another CKEditor builder because their builder is crazy and changes... Gauthier |
|
Once again, if you check my code, I am not building a new |
|
I do not know what is the best solution, we just need regular updates and release I think. Anyway, if tests with version 4.5.3 are ok, we can just forget about 4.4.8 also... See you, Gauthier |
- scayt plugin was missing - widget and lineutils dependencies of image2 were also missing - make script more robusts
|
@gbastien Can you check if c.ckeditor works for you now ? scayt needs to be enabled by installing the plugin. Was it the case previously ? |
|
Hi @gotcha what do you mean by "installing the plugin"? Scayt is available if you download the full version of ckeditor and will be activated together with ckeditor and other plugins. Isn't it the case anymore? +++ Gauthier |
|
I am asking if installing collective.ckeditor was enough for scayt to be enabled. Or if you had anything else to do ? |
so that they are enabled by default
|
@gbastien Ok, scayt plugin used to be loaded without any config change. I have fixed the build process. |
|
Merged with #46 |
Upgrade Ckeditor to 4.4.8
Add scripts to automate update of ckeditor