Skip to content

Commit

Permalink
Skip blind excepts for now
Browse files Browse the repository at this point in the history
We need to fix this later.
  • Loading branch information
hvelarde committed Mar 31, 2016
1 parent 00b0cb5 commit a204e3d
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion buildout.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ clean-lines-exclude = ${buildout:directory}/src/collective/cover/static/js/vendo
csslint = True
csslint-bin = bin/csslint
debug-statements = True
flake8-ignore = D001,E501,P001,T000
flake8-ignore = B901,D001,E501,P001,T000
flake8-max-complexity = 12
jshint = True
jshint-bin = bin/jshint
Expand Down
2 changes: 1 addition & 1 deletion src/collective/cover/browser/cover.py
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ def render(self):
try:
tile_instance.replace_with_uuids(uuids)
html = tile_instance()
except:
except: # FIXME: B901 blind except: statement
# XXX: Pass silently ?
pass

Expand Down
2 changes: 1 addition & 1 deletion src/collective/cover/tiles/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,7 @@ def create(self, fieldname, direction='thumbnail',
height=height, width=width, **parameters)
except (ConflictError, KeyboardInterrupt):
raise
except Exception:
except Exception: # FIXME: B901 blind except: statement
logging.exception(
'could not scale "{0}" of {1}'.format(
repr(orig_value),
Expand Down
2 changes: 1 addition & 1 deletion src/collective/cover/widgets/textlinessortable.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def thumbnail(self, item):
scales = item.restrictedTraverse('@@images')
try:
return scales.scale('image', 'tile')
except:
except: # FIXME: B901 blind except: statement
return None

def isExpired(self, item):
Expand Down

0 comments on commit a204e3d

Please sign in to comment.