Select multiple class in cover configuration #779
Conversation
rodfersou
force-pushed
the
select-multiple-class
branch
from
a9f07b7
to
4df4e1f
Compare
| </option> | ||
| </tal:classes> | ||
| </select> | ||
| <input class="cssclasswidget" type="button" value="Select options ▼" |
There was a problem hiding this comment.
value needs to be internationalized.
| @@ -731,3 +731,45 @@ input[type='submit'].btn::-moz-focus-inner | |||
| { | |||
| cursor: move; | |||
| } | |||
| body .cssclasswidget | |||
There was a problem hiding this comment.
how are we going to deal with intermediate caching servers and this change?
There was a problem hiding this comment.
the simplest solution in this case is to rename the resource name appending the modify date.
| @@ -1,4 +1,112 @@ | |||
| (function($) { | |||
| var CSSClassWidget = (function() { | |||
There was a problem hiding this comment.
how are we going to deal with intermediate caching servers and this change?
There was a problem hiding this comment.
this needs an upgrade step to cook JS files since this file is into jsregistry
| <input class="cssclasswidget" type="button" value="Select options ▼" |
There was a problem hiding this comment.
value needs to be internationalized.
| items = [ | ||
| { | ||
| key: value | ||
| for key, value in item.iteritems() |
There was a problem hiding this comment.
iteritems() works on Python 2 only; you need to import it from six; check http://python-future.org/compatible_idioms.html#iterating-through-dict-keys-values-items
CHANGES.rst
Outdated
| @@ -6,6 +6,9 @@ There's a frood who really knows where his towel is. | |||
| 1.6b6 (unreleased) | |||
| ^^^^^^^^^^^^^^^^^^ | |||
|
|
|||
| - Select multiple CSS class in cover configuration. | |||
There was a problem hiding this comment.
"Allow selection of multiple CSS classes in tile configuration."
| @@ -51,13 +51,9 @@ | |||
| <div id="slider"></div> | |||
| </div> | |||
| <div id="class-chooser" title="Choose Class"> | |||
There was a problem hiding this comment.
"Choose classes"; title needs to be internationalized.
src/collective/cover/testing.py
Outdated
| r = i % 4 * 64 | ||
| g = i % 8 * 32 | ||
| b = i % 16 * 16 | ||
| r = i % 4 * 64 # noqa: S001 |
There was a problem hiding this comment.
don't include this as this bug is already fixed: gforcada/flake8-pep3101#16
what version of flake8-pep3101 are you using?
There was a problem hiding this comment.
I don't know how to check this out
rodfersou
force-pushed
the
select-multiple-class
branch
from
2b2359b
to
676f3f0
Compare
rodfersou
force-pushed
the
select-multiple-class
branch
from
676f3f0
to
9d950fc
Compare
WIP