Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change semantics for the "advanced" permission and introduce new "technical" permission. #229

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

thet
Copy link
Member

@thet thet commented Jun 10, 2020

Change semantics for the "advanced" permission and introduce new "technical" permission.
To better support use cases for "power users" while not overloading them with complex fields where a technical understanding is necessary the permissions are changed as follows:

"Edit Advanced Fields":

  • IEasyForm.submitLabel
  • IEasyForm.useCancelButton
  • IEasyForm.resetLabel
  • IEasyForm.form_tabbing
  • IEasyForm.default_fieldset_label
  • IFieldExtender.field_widget
  • IFieldExtender.validators

"Edit Technical Fields":

  • IEasyForm.method
  • IEasyForm.unload_protection
  • IEasyForm.CSRFProtection
  • IEasyForm.forceSSL
  • IMailer.replyto_field
  • IMailer.xinfo_headers
  • IMailer.additional_headers

Note: no upgrade step provided because this will be covered by the upgrade step in this PR:
#224

@thet thet requested a review from reinhardt June 10, 2020 10:26
@thet thet force-pushed the thet-technical-permissions branch from b144a38 to 2d9496d Compare June 10, 2020 10:27
Copy link
Contributor

@reinhardt reinhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@coveralls
Copy link

coveralls commented Jun 10, 2020

Coverage Status

Coverage increased (+0.07%) to 84.458% when pulling 2d9496da33ea9e8ac1c37755d0e665d1b979f44d on thet-technical-permissions into f864f62 on master.

@thet
Copy link
Member Author

thet commented Jun 10, 2020

For reference - the field overlay for managers:
Screenshot from 2020-06-10 12-32-57

... and for normal users:
Screenshot from 2020-06-10 12-34-26

…hnical" permission.

To better support use cases for "power users" while not overloading them with complex fields where a technical understanding is necessary the permissions are changed as follows:

"Edit Advanced Fields":
- IEasyForm.submitLabel
- IEasyForm.useCancelButton
- IEasyForm.resetLabel
- IEasyForm.form_tabbing
- IEasyForm.default_fieldset_label
- IFieldExtender.field_widget
- IFieldExtender.validators

"Edit Technical Fields":
- IEasyForm.method
- IEasyForm.unload_protection
- IEasyForm.CSRFProtection
- IEasyForm.forceSSL
- IMailer.replyto_field
- IMailer.xinfo_headers
- IMailer.additional_headers
@thet thet force-pushed the thet-technical-permissions branch from 2d9496d to 4de6184 Compare June 10, 2020 10:40
@thet thet merged commit 7a71877 into master Jun 10, 2020
@thet thet deleted the thet-technical-permissions branch June 10, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants