Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment with ijson to support large files #4

Merged
merged 1 commit into from
May 5, 2021
Merged

Experiment with ijson to support large files #4

merged 1 commit into from
May 5, 2021

Conversation

pbauer
Copy link
Member

@pbauer pbauer commented Apr 27, 2021

See #3

@pbauer pbauer requested a review from fredvd April 27, 2021 19:28
Copy link
Member

@fredvd fredvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR with a 7.5Gb File.json full of base64 blobs, migrating from Plone 4 to Plone 5.2. It worked flawlessly, after I had raised Waitress it's max_request_body_size from default 1Gb to 10Gb. All other content were imported fine.

Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ready for merge.

@fredvd fredvd merged commit 3ee1be4 into main May 5, 2021
@fredvd
Copy link
Member

fredvd commented May 5, 2021

@pbauer I've merged this one because I need it present to simplify testing the other branch with the AT->DX export switches/modifiers. If you had another reason to delay this merge: Sorry ;-)

@pbauer
Copy link
Member Author

pbauer commented May 5, 2021

that's fine.

Did you see the branch in #11? I just now rebased it on the current main.
I also have some code to migrate topics that uses the criteria-migrators from p.a.c. to migrate ATCriteria to querystrings.
I will put that in another branch since it is not ready for prime time and still brittle. I plan to migrate a portal with > 1500 ATTopics 🙄

@fredvd
Copy link
Member

fredvd commented May 5, 2021

Yes I noticed that branch. I'm testing it this afternoon/evening on my current migration project. I've asked Maurits if he can take a look at the import from server feature for this migration. Uploading through the browser for the bulk contenttypes is too tricky and only feasible if the browser and site are on the same machine.

Collections are the most painful default content type to try to migrate. Skeleton in the closet to support these in c.exportimport are old style collections still present in some Plone 4 sites.

@pbauer pbauer deleted the ijson branch May 12, 2021 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants