New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add print plugin, use npm package via yarn #51
Conversation
Add the print plugin by default. Use ``yarn`` to manage JavaScript dependencies and upgrade resource paths to new location.
@@ -47,7 +47,7 @@ def setUp(self): | |||
|
|||
def test_upgrade_to_2_registrations(self): | |||
version = self.setup.getLastVersionForProfile(self.profile_id)[0] | |||
self.assertGreaterEqual(version, self.to_version) | |||
self.assertGreaterEqual(int(version), int(self.to_version)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The string in int cast is necessary. The tests passed before this change for metadata version 9 only by the way strings are compared in python. See below:
Comparison of "10" with other numbers-as-strings:
>>> "10" >= "0"
True
>>> "10" >= "1"
True
>>> "10" >= "2"
False
>>> "10" >= "3"
False
>>> "10" >= "4"
False
>>> "10" >= "5"
False
>>> "10" >= "6"
False
>>> "10" >= "7"
False
>>> "10" >= "8"
False
>>> "10" >= "9"
False
>>> "10" >= "10"
True
Comparison of "9" with other numbers-as-strings:
>>> "9" >= "0"
True
>>> "9" >= "1"
True
>>> "9" >= "2"
True
>>> "9" >= "3"
True
>>> "9" >= "4"
True
>>> "9" >= "5"
True
>>> "9" >= "6"
True
>>> "9" >= "7"
True
>>> "9" >= "8"
True
>>> "9" >= "9"
True
>>> "9" >= "10"
True
travis tests are failing in the moment because of the Plone 4.3 integration. I don't like having the Any comments? |
please, use sc.recipe.staticresources https://github.com/simplesconsultoria/sc.recipe.staticresources and webpack for this (we are migrating all of our addons to use it) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after merging #53 this is no longer the way to fix this issue.
superseded by #59 |
node_modules
is defined.Fixes #50