Fix exception related with new version of plone protect related with …

…returning empty string in the browser view
collective · Aug 14, 2017 · 7a8e014 · 7a8e014
1 parent efb2d97
commit 7a8e014
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -4,7 +4,8 @@ Changelog
 1.2b2 (unreleased)
 ------------------
 
-- Nothing changed yet.
+- Fix exception related with new version of plone protect related with returning empty string in the browser view (fixes `#64`_).
+  [rodfersou]
 
 
 1.2b1 (2016-06-21)
@@ -140,3 +141,4 @@ Changelog
 .. _`#19`: https://github.com/collective/collective.liveblog/issues/19
 .. _`#31`: https://github.com/collective/collective.liveblog/issues/31
 .. _`#32`: https://github.com/collective/collective.liveblog/issues/32
+.. _`#64`: https://github.com/collective/collective.liveblog/issues/64
diff --git a/src/collective/liveblog/browser/recent_updates.py b/src/collective/liveblog/browser/recent_updates.py
@@ -82,6 +82,10 @@ def __call__(self):
         self.request.RESPONSE.setHeader('Cache-Control', 'public')
         self.request.RESPONSE.setHeader('Expires', expires)
         self.request.RESPONSE.setHeader('Last-Modified', last_modified)
+        self.latest_microupdates = self.get_latest_microupdates()
+        # https://github.com/plone/plone.protect/issues/64
+        if len(self.latest_microupdates) == 0:
+            return ''
         return self.index()
 
     # FIXME: caching this function will speed up the rendering of this

diff --git a/src/collective/liveblog/browser/templates/recent_updates.pt b/src/collective/liveblog/browser/templates/recent_updates.pt
@@ -6,7 +6,7 @@
 <body tal:omit-tag="">
     <section id="micro-updates" tal:omit-tag="">
       <article class="microupdate" data-timestamp="" itemprop="comment" itemscope itemtype="http://schema.org/Comment"
-          tal:repeat="update view/get_latest_microupdates"
+          tal:repeat="update view/latest_microupdates"
           tal:attributes="data-timestamp update/timestamp">
         <h2 class="microupdate-title" itemprop="headline"
             tal:condition="update/title"