Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix folder full view #103

Merged
merged 2 commits into from
Jan 6, 2017
Merged

Fix folder full view #103

merged 2 commits into from
Jan 6, 2017

Conversation

hvelarde
Copy link
Member

closes #102

@rodfersou
Copy link
Member

@hvelarde I don't know why this test pass just in one case with travis.

locally it always pass, even if I try to simulate travis conditions where it does not pass.

@idgserpro
Copy link
Member

We suggest exporting the logs like collective.cover does to check whats rendered, or even printing on the test itself somehow.

@rodfersou
Copy link
Member

@hvelarde can you point me please if we need just to change .travis.yml to make it works?

@hvelarde
Copy link
Member Author

hvelarde commented Jan 2, 2017

I have no idea why is this failing, but the message seems clear.

@rodfersou
Copy link
Member

@hvelarde I was talking about @idgserpro suggestion above

@hvelarde
Copy link
Member Author

hvelarde commented Jan 3, 2017

@rodfersou use this and run the tests; they will fail locally:

bin/buildout buildout:test-eggs=collective.cover[test]

@rodfersou
Copy link
Member

@hvelarde green \o/

@@ -23,9 +23,9 @@ Test Folder Full View
Open Add New Menu
Click Link css=a#folder
Page Should Contain Add Folder
Input Text css=#form-widgets-IDublinCore-title Test Folder
Input Text css=#form-widgets-IDublinCore-title,#title Test Folder
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an interesting trick; so how does it work? if the first element is not present the we use the second one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly, this is a css selector

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do robots accepts all css selectors? Did you try this or is this trick in the documentation?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK RF accepts all CSS 1 and CSS 2 selectors http://www.w3schools.com/cssref/css_selectors.asp

I vaguely remember to have problems with some Pseudo elements and Pseudo classes https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Selectors

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can make some tests with last version of https://pypi.python.org/pypi/cssselect package to see if all css selectos work with RF, we are using the version 0.3 instead of 1.0.0

@hvelarde hvelarde merged commit ed5a625 into master Jan 6, 2017
@hvelarde hvelarde deleted the issue_102 branch January 6, 2017 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content core fields not shown in folder full view
3 participants