-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix folder full view #103
Fix folder full view #103
Conversation
73b0154
to
882093c
Compare
6b8fbcb
to
4992174
Compare
@hvelarde I don't know why this test pass just in one case with travis. locally it always pass, even if I try to simulate travis conditions where it does not pass. |
We suggest exporting the logs like collective.cover does to check whats rendered, or even printing on the test itself somehow. |
@hvelarde can you point me please if we need just to change .travis.yml to make it works? |
I have no idea why is this failing, but the message seems clear. |
@hvelarde I was talking about @idgserpro suggestion above |
@rodfersou use this and run the tests; they will fail locally:
|
@hvelarde green \o/ |
@@ -23,9 +23,9 @@ Test Folder Full View | |||
Open Add New Menu | |||
Click Link css=a#folder | |||
Page Should Contain Add Folder | |||
Input Text css=#form-widgets-IDublinCore-title Test Folder | |||
Input Text css=#form-widgets-IDublinCore-title,#title Test Folder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is an interesting trick; so how does it work? if the first element is not present the we use the second one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exactly, this is a css selector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do robots accepts all css selectors? Did you try this or is this trick in the documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK RF accepts all CSS 1 and CSS 2 selectors http://www.w3schools.com/cssref/css_selectors.asp
I vaguely remember to have problems with some Pseudo elements and Pseudo classes https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Selectors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can make some tests with last version of https://pypi.python.org/pypi/cssselect package to see if all css selectos work with RF, we are using the version 0.3 instead of 1.0.0
closes #102