Don't replace a link if the result is a link

collective · Aug 14, 2013 · 8191621 · 8191621
1 parent fe813c5
commit 8191621
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/CHANGES.txt b/CHANGES.txt
@@ -4,7 +4,7 @@ Changelog
 2.0a5 (unreleased)
 ------------------
 
-- Nothing changed yet.
+- Don't replace a link if the result is a link [toutpt]
 
 
 2.0a4 (2013-05-17)

diff --git a/collective/oembed/jquery.oembed.js b/collective/oembed/jquery.oembed.js
@@ -253,9 +253,9 @@
 
 	/* Public functions */
 	$.fn.oembed.insertCode = function (container, embedMethod, oembedData) {
+		var html = $(oembedData.code);
 		if (oembedData === null)
 			return;
-
 		switch (embedMethod) {
 		case "auto":
 			if (container.attr("href") !== null) {
@@ -266,8 +266,10 @@
 			}
 			break;
 		case "replace":
+			if (html.is("a")){
+				break;
+			}
 			if (container.hasClass("oembed-responsive")){
-				var html = $(oembedData.code);
 				if (html.is("iframe") || html.is("object") || html.is("embed")){
 					var width = parseInt(html.attr("width"), null), height = parseInt(html.attr("height"), null);
 					var ratio = height / width;