More dexterity-related fixes #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty. Simplified UploadFileTypeVocabulary, since it now relies on _listTypesForInterface to make the distinction. Lastly, some flake8 for good measure
tdesvenain
added a commit
that referenced
this pull request
Mar 12, 2013
More dexterity-related fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request continues #26
If the portlet is configured to filter by portal_type, we also need to make sure that we don't depend on the existence of the archetype_tool.
Therefore,
_listTypesForInterfacein quick_upload now takes care of handling AT vs dexterity. Note: the signature has changed. Instead of taking an interface as argument (previously this was AT-specific), it takes a string, either "file" or "image". The method then looks up the correct interface for the requested type, based on whether AT or dexterity is present.The
UploadFileTypeVocabularyfor the portlet has gotten simpler, since all distinction between AT and dexterity has been moved to_listTypesForInterface.(I also did some pep8 / flake8 cleanup, so that the diff seems larger than it actually is)