Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mangler fixes #20

Closed
wants to merge 49 commits into from
Closed

Mangler fixes #20

wants to merge 49 commits into from

Conversation

keul
Copy link
Member

@keul keul commented Nov 13, 2013

We experienced some issues using collective.solr with new style collections and some range criterion.

First of all: we seen a "min:max" in ranges dict, but Plone use "minmax". We don't know if also min:max is needed. If not: probably also tests must be updated.

New collection sometimes pass a date string not in iso format (like "12/11/2013") and iso8601date is not fixing it.

@keul
Copy link
Member Author

keul commented Nov 18, 2013

Update: we found that the contentlisting of events types is broken just because the FlareContentListingObject does not provide a "start" (end) method.
Instead of providing it directly why not trying to call in on the flare object instead?

@keul
Copy link
Member Author

keul commented Mar 27, 2014

We updated the pull request with most recent changes.

All tests are running for me, but not for Travis... no idea why. Any change of seeing this branch merged or at least reviewed.

Also: we see some mess in this package release process. No tag for versions 0.4 or 0.4.1, no official release for version 0.4.1, ...

@tisto
Copy link
Member

tisto commented May 14, 2014

I just fixed the travis build. Feel free to re-submit smaller pull requests that I can review individually. I will close this pull request for now.

@tisto tisto closed this May 14, 2014
@cekk
Copy link
Contributor

cekk commented May 14, 2014

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants