Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring with plone/meta #53

Merged
merged 5 commits into from
Jun 12, 2024
Merged

Conversation

mamico
Copy link
Contributor

@mamico mamico commented Jun 7, 2024

No description provided.

@mamico mamico marked this pull request as ready for review June 7, 2024 14:06
@mamico
Copy link
Contributor Author

mamico commented Jun 7, 2024

@JeffersonBledsoe I restarted the same work from scratch here that you began in #42. All the checks are green now. Please double-check to see if I'm missing anything that you already caught. thanks

Copy link
Member

@JeffersonBledsoe JeffersonBledsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mamico Looks better than what I started in #53 ! I've closed my PR, LGTM!

@mamico mamico merged commit e489116 into main Jun 12, 2024
7 checks passed
@mamico mamico deleted the config-with-default-template-721299ce branch June 12, 2024 04:10
@mamico mamico mentioned this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants