Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable options #1

Merged
merged 3 commits into from
Aug 9, 2021

Conversation

erral
Copy link
Member

@erral erral commented Aug 6, 2021

We have been working to use EU Login with this plugin because it implements OpenID connect.

Nevertheless we have found that we needed to do some changes in the implementation, such as:

  • Add a configurable option to select which scopes to use
  • Add an option to use PKCE
  • We found that EU Login has some strange implementation, where the email_verified and phone_number_verified boolean values are sent as string values ('true'), so the automatic validation that oidc library does fails with EU Login. So we have added an option to use a modified version of the validation that accepts 'true' values as real JSON true and thus python True.
  • We have also found that EU Login does not have the userinfo endpoint, so we now check if the endpoint exists before querying it. If the endpoint is not defined, we extract the userinfo from the id_token, with is already decoded in the previous step (obtaining the access_token).

We want also to work on the came_from/next_url thing, but had no time yet. Will check it after holidays :)

@mamico
Copy link
Collaborator

mamico commented Aug 9, 2021

LGTM

@mamico mamico merged commit 0cc43b5 into collective:main Aug 9, 2021
@erral erral deleted the add-configurable-options branch November 27, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants