Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been working to use EU Login with this plugin because it implements OpenID connect.
Nevertheless we have found that we needed to do some changes in the implementation, such as:
email_verified
andphone_number_verified
boolean values are sent as string values ('true'
), so the automatic validation that oidc library does fails with EU Login. So we have added an option to use a modified version of the validation that accepts'true'
values as real JSONtrue
and thus pythonTrue
.userinfo
endpoint, so we now check if the endpoint exists before querying it. If the endpoint is not defined, we extract the userinfo from the id_token, with is already decoded in the previous step (obtaining the access_token).We want also to work on the came_from/next_url thing, but had no time yet. Will check it after holidays :)