Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collective.js.boostrap as dependencie #13

Merged
merged 6 commits into from Mar 6, 2013
Merged

Conversation

toutpt
Copy link
Member

@toutpt toutpt commented Mar 6, 2013

I have work on split this addon from twitter bootstrap itself. I believe providing external framework should be done in dedicated addon, it's more easey to maintain.

I have also reduce skin directory to only on used only to override existing skin resources.

Great addon by the way, I will use it as base theme for my current project.

If any issues with this work, please contact me.

…ould only be used to customize

  already existing resource. Use browser:resource instead [toutpt]
- Add dependencies over collective.js.bootstrap. More easy to manage upgrade [toutpt]
@erral
Copy link
Member

erral commented Mar 6, 2013

Very nice idea!!!

Just a question:

Is really needed to add c.js.bootstrap's CSS and JS files into our cssregistry.xml? Wouldn't be easier to do that in c.js.bootstrap and in this product (plonetheme.bootstrap), just install the profile as a dependency in metadata.xml?

@toutpt
Copy link
Member Author

toutpt commented Mar 6, 2013

Good question !

I believe not because twitter bootstrap css conflict with sunburst, so installing the addon would break Plone.
Use bootstrap need a real integration and this theme is the one.

@erral
Copy link
Member

erral commented Mar 6, 2013

ok!

2013/3/6 JeanMichel FRANCOIS aka toutpt notifications@github.com

Good question !

I believe not because twitter bootstrap css conflict with sunburst, so
installing the addon would break Plone.
Use bootstrap need a real integration and this theme is the one.


Reply to this email directly or view it on GitHubhttps://github.com//pull/13#issuecomment-14500017
.

Mikel Larreategi
mlarreategi@codesyntax.com

CodeSyntax
Azitaingo Industrialdea 3 K
E-20600 Eibar
Tel: (+34) 943 82 17 80

erral added a commit that referenced this pull request Mar 6, 2013
Add collective.js.boostrap as dependencie
@erral erral merged commit aa585ae into collective:master Mar 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants