-
Notifications
You must be signed in to change notification settings - Fork 23
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove redundant metadata from Twitter plugin as it can use Open Grap…
…h properties as fall back. (#131) The following changes were also implemented: * widgets now respect users' privacy via implementation of the 'twitter:dnt' property. * Tweet Button code was updated to use current best practices. * plugin code was cleaned up and refactored; it must be faster now and consume less memory. Note that 'data-lang' attribute was removed as Twitter must be able to discover the content language automatically. More information: * https://dev.twitter.com/web/tweet-button * https://dev.twitter.com/web/overview/privacy
- Loading branch information
Showing
6 changed files
with
75 additions
and
113 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,83 +1,63 @@ | ||
| # -*- coding:utf-8 -*- | ||
| """Helper view to generate the Tweet Button widget. | ||
| More information: | ||
| * https://dev.twitter.com/web/tweet-button | ||
| * https://dev.twitter.com/web/overview/privacy | ||
| """ | ||
| from Acquisition import aq_inner | ||
| from plone import api | ||
| from plone.api.exc import InvalidParameterError | ||
| from Products.CMFPlone.utils import safe_unicode | ||
| from Products.Five import BrowserView | ||
| from Products.Five.browser.pagetemplatefile import ViewPageTemplateFile | ||
| from Products.PythonScripts.standard import url_quote | ||
| from sc.social.like.behaviors import ISocialMedia | ||
| from sc.social.like.config import IS_PLONE_5 | ||
| from sc.social.like.interfaces import ISocialLikeSettings | ||
| from sc.social.like.utils import get_content_image | ||
| from sc.social.like.utils import get_language | ||
| from urllib import urlencode | ||
| from zope.component import getMultiAdapter | ||
|
|
||
|
|
||
| class PluginView(BrowserView): | ||
|
|
||
| twitter_enabled = False | ||
| language = 'en' | ||
| """Helper view to generate the Tweet Button widget.""" | ||
|
|
||
| metadata = ViewPageTemplateFile('templates/metadata.pt') | ||
| plugin = ViewPageTemplateFile('templates/plugin.pt') | ||
| link = ViewPageTemplateFile('templates/link.pt') | ||
|
|
||
| def __init__(self, context, request): | ||
| self.context = context | ||
| self.title = context.title | ||
| self.description = context.Description() | ||
| self.context = aq_inner(context) | ||
| self.request = request | ||
| # FIXME: the following could rise unexpected exceptions | ||
| # move it to a new setup() method | ||
| # see: http://docs.plone.org/develop/plone/views/browserviews.html#creating-a-view | ||
| self.portal_state = getMultiAdapter((self.context, self.request), | ||
| name=u'plone_portal_state') | ||
| self.portal = self.portal_state.portal() | ||
| self.site_url = self.portal_state.portal_url() | ||
| self.portal_title = self.portal_state.portal_title() | ||
| self.url = context.absolute_url() | ||
| self.language = get_language(context) | ||
| self.image = get_content_image(context) | ||
| self.urlnoscript = ( | ||
| u'http://twitter.com/home?status=' + | ||
| url_quote(u'{0} - {1} via {2}'.format( | ||
| safe_unicode(self.context.title), | ||
| self.context.absolute_url(), | ||
| self.via) | ||
| ) | ||
| ) | ||
|
|
||
| @property | ||
| def is_plone_5(self): | ||
| return IS_PLONE_5 | ||
|
|
||
| @property | ||
| def typebutton(self): | ||
| record = ISocialLikeSettings.__identifier__ + '.typebutton' | ||
| try: | ||
| return api.portal.get_registry_record(record) | ||
| except InvalidParameterError: | ||
| return '' | ||
| def portal_url(self): | ||
| portal = api.portal.get() | ||
| return portal.absolute_url() | ||
|
|
||
| def canonical_url(self): | ||
| """Return canonical URL if available; otherwise, context URL.""" | ||
| if ISocialMedia.providedBy(self.context): | ||
| return self.context.canonical_url | ||
| else: | ||
| return self.context.absolute_url() | ||
|
|
||
| @property | ||
| def via(self): | ||
| record = ISocialLikeSettings.__identifier__ + '.twitter_username' | ||
| try: | ||
| return api.portal.get_registry_record(record) | ||
| except InvalidParameterError: | ||
| return '' | ||
| return api.portal.get_registry_record(record, default='') | ||
|
|
||
| def share_link(self): | ||
| params = dict( | ||
| text=safe_unicode(self.context.Title()).encode('utf-8'), | ||
| url=self.context.absolute_url(), | ||
| ) | ||
| if self.via: | ||
| params['via'] = self.via | ||
| params = { | ||
| 'text': self.context.Title(), | ||
| 'url': self.context.absolute_url(), | ||
| } | ||
|
|
||
| via = self.via() | ||
| if via: | ||
| params['via'] = via | ||
|
|
||
| url = 'https://twitter.com/intent/tweet?' + urlencode(params) | ||
| return url | ||
|
|
||
| def image_url(self): | ||
| """Return image URL.""" | ||
| return self.image.url if self.image else None | ||
| def dnt(self): | ||
| record = ISocialLikeSettings.__identifier__ + '.do_not_track' | ||
| return api.portal.get_registry_record(record, default=False) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,13 @@ | ||
| <tal:twitter i18n:domain="sc.social.like"> | ||
| <!-- Twitter --> | ||
| <a href="https://twitter.com/intent/tweet" | ||
| class="slPrivacy" | ||
| title="Tweet it! (open in new window)" | ||
| tal:attributes="href view/share_link" | ||
| onclick="javascript:window.open(this.href, '', 'menubar=no,toolbar=no,resizable=yes,scrollbars=yes,height=600,width=600');return false;" | ||
| i18n:attributes="title"> | ||
| <img src="share-linkedin.png" | ||
| alt="Tweet it!" | ||
| i18n:attributes="alt" | ||
| tal:attributes="src string:${view/site_url}/++resource++sl_images/share-twitter.png" /> | ||
| </a> | ||
| </tal:twitter> | ||
| <!-- Twitter --> | ||
| <a class="slPrivacy" | ||
| href="https://twitter.com/intent/tweet" | ||
| title="Tweet (opens in new window)" | ||
| tal:attributes="href view/share_link" | ||
| onclick="javascript:window.open(this.href, '', 'menubar=no,toolbar=no,resizable=yes,scrollbars=yes,height=600,width=600');return false;" | ||
| i18n:domain="sc.social.like" | ||
| i18n:attributes="title"> | ||
| <img src="share-twitter.png" | ||
| alt="Tweet" | ||
| i18n:attributes="alt" | ||
| tal:attributes="src string:${view/portal_url}/++resource++sl_images/share-twitter.png" /> | ||
| </a> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,7 @@ | ||
| <tal:twitter> | ||
| <!-- Twitter --> | ||
| <a href="https://twitter.com/share" | ||
| class="twitter-share-button" | ||
| tal:attributes="data-count view/typebutton; | ||
| data-via view/via; | ||
| data-url view/url; | ||
| data-lang view/language; | ||
| data-text here/Title;">Tweet</a> | ||
| <script>!function(d,s,id){var js,fjs=d.getElementsByTagName(s)[0],p=/^http:/.test(d.location)?'http':'https';if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src=p+'://platform.twitter.com/widgets.js';fjs.parentNode.insertBefore(js,fjs);}}(document, 'script', 'twitter-wjs');</script> | ||
| <noscript> | ||
| <a tal:attributes="href view/urlnoscript">Tweet</a> | ||
| </noscript> | ||
| </tal:twitter> | ||
| <!-- Twitter --> | ||
| <a class="twitter-share-button" | ||
| href="https://twitter.com/intent/tweet" | ||
| tal:attributes="data-text here/Title; | ||
| data-url view/canonical_url; | ||
| data-via view/via">Tweet</a> | ||
| <script async src="//platform.twitter.com/widgets.js" charset="utf-8"></script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters