Remove redundant metadata from Twitter plugin as it can use Open Graph properties as fall back #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodfersou
reviewed
Sep 1, 2017
| data-text here/Title;">Tweet</a> | ||
| <script>!function(d,s,id){var js,fjs=d.getElementsByTagName(s)[0],p=/^http:/.test(d.location)?'http':'https';if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src=p+'://platform.twitter.com/widgets.js';fjs.parentNode.insertBefore(js,fjs);}}(document, 'script', 'twitter-wjs');</script> | ||
| <noscript> | ||
| <a tal:attributes="href view/urlnoscript">Tweet</a> |
There was a problem hiding this comment.
I vote to keep this fallback when there is no javascript available (screen readers will thank you)
There was a problem hiding this comment.
that's not needed: the associated <script> tag is no longer there.
There was a problem hiding this comment.
I still see a <script> tag (but with src attribute), and this was a feature that will break after this merge. People that could tweet with screen readers will not be able to do it anymore.
rodfersou
requested changes
Sep 1, 2017
…h properties as fall back. The following changes were also implemented: * widgets now respect users' privacy via implementation of the 'twitter:dnt' property. * Tweet Button code was updated to use current best practices. * plugin code was cleaned up and refactored; it must be faster now and consume less memory. Note that 'data-lang' attribute was removed as Twitter must be able to discover the content language automatically. More information: * https://dev.twitter.com/web/tweet-button * https://dev.twitter.com/web/overview/privacy
claytonc
pushed a commit
that referenced
this pull request
Sep 27, 2017
…h properties as fall back. (#131) The following changes were also implemented: * widgets now respect users' privacy via implementation of the 'twitter:dnt' property. * Tweet Button code was updated to use current best practices. * plugin code was cleaned up and refactored; it must be faster now and consume less memory. Note that 'data-lang' attribute was removed as Twitter must be able to discover the content language automatically. More information: * https://dev.twitter.com/web/tweet-button * https://dev.twitter.com/web/overview/privacy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #112
The following changes were also implemented:
Note that 'data-lang' attribute was removed as Twitter must be able to discover the content language automatically.
More information: