Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sphinx CodeBlock location since Sphinx 4.0.0 #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cilq
Copy link

@cilq cilq commented Mar 8, 2022

sphinx.directives.CodeBlock has been deprecated since 2.1.0 and has been moved to sphinx.directives.code.CodeBlock since a86346a

@datakurre
Copy link
Collaborator

@cilq Really nice! Thanks. I will look into this, fix CI for both >=4 and <4 and make a release later this week.

Since sphinx-doc/sphinx@a86346 the CodeBlock directive has to be imported from sphinx.directives.code
@thet
Copy link
Member

thet commented Apr 21, 2023

@datakurre this looks like an easy fix. Can we merge this and make a release?

thet added a commit to plone/plone.app.mosaic that referenced this pull request Apr 21, 2023
Disable source checkout of sphinxcontrib_robotframework due to an error
with "--install-option='--pre'" in requirement files and recent pip
versions.

As soon this is fixed upstream we can re-enable it.

Ref:

- mxstack/mxdev#30
- collective/sphinxcontrib-robotframework#6
thet added a commit to plone/plone.app.mosaic that referenced this pull request Apr 21, 2023
Disable source checkout of sphinxcontrib_robotframework due to an error
with "--install-option='--pre'" in requirement files and recent pip
versions.

As soon this is fixed upstream we can re-enable it.

Ref:

- mxstack/mxdev#30
- collective/sphinxcontrib-robotframework#6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants