Fix usage of "--install-option='pre'" and use "--pre" option in requirements files instead. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irements files instead. The install options is deprecated in pip 23 which Plone switched to recently. More info: - pypa/pip#11358 - https://discuss.python.org/t/passing-command-line-arguments-to-pip-install-after-install-options-deprecation/22981/6
|
@fredvd I referenced you as co-author as you brought up plone/plone.app.mosaic@94fb86e |
thet
added a commit
to plone/plone.app.mosaic
that referenced
this pull request
Apr 21, 2023
Disable source checkout of sphinxcontrib_robotframework due to an error with "--install-option='--pre'" in requirement files and recent pip versions. As soon this is fixed upstream we can re-enable it. Ref: - mxstack/mxdev#30 - collective/sphinxcontrib-robotframework#6
thet
added a commit
to plone/plone.app.mosaic
that referenced
this pull request
Apr 21, 2023
Disable source checkout of sphinxcontrib_robotframework due to an error with "--install-option='--pre'" in requirement files and recent pip versions. As soon this is fixed upstream we can re-enable it. Ref: - mxstack/mxdev#30 - collective/sphinxcontrib-robotframework#6
|
@thet Thanks. I found a thread on community.plone.org this morning from 2 days ao where @jensens mentionned this and working on a fix . Also notified @mauritsvanrees this morning this could cause other places in for example ci/cd to fail. Hmmm should mention @plone/ci-team here probably, that's easier. https://community.plone.org/t/mxdev-and-pip-option-install-option-pre/17386/3 |
|
Thanks so much for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The install options is deprecated in pip 23 which Plone switched to recently.
More info:
NOTE: this is breaking Plone PR builds currently.
See: https://github.com/plone/plone.app.mosaic/actions/runs/4768963939/jobs/8478862820?pr=535