Optimize reconstructing attributes in #revisions #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbrisker
reviewed
Jan 30, 2018
lib/audited/auditor.rb
Outdated
| revision_with(reconstruct_attributes(ancestors).merge(version: audit.version)) | ||
| revision_attributes = previous_attributes.merge(audit.new_attributes) | ||
| previous_attributes = revision_attributes | ||
| revision_with(revision_attributes.merge!(version: audit.version)) |
There was a problem hiding this comment.
I think you don't actually need the extra variable here, maybe something like:
previous_attributes.merge!(audit.new_attributes)
revision_with(previous_attributes.merge!(version: audit.version))
fatkodima
force-pushed
the
optimize-revisions-hashes
branch
from
567614f
to
99d1289
Compare
|
Updated this. Failing tests are not related to my changes. I fixed them in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #402.
Also replaced
.empty?with.exists?, because for older rails'es (at least for 4.0.0).empty?is implemented throughCOUNT, instead of throughSELECT 1like in new versions.