Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds redacted option #485

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

JonathanWThom
Copy link
Contributor

  • In order to record that changes occurred, without storing sensitive
    values, pass the redacted option.

  • Redacted values default to '[REDACTED]' but can be customized with
    the redaction_value option.

class User
    audited redacted: [:password, :ssn], redaction_value: SecureRandom.uuid
end

* In order to record that changes occurred, without storing sensitive
values, pass the `redacted` option.

* Redacted values default to `'[REDACTED]'` but can be customized with
the `redaction_value` option.

```
class User
    audited redacted: [:password, :ssn], redaction_value:
SecureRandom.uuid
end
```

* A lot of this was based on the work done
[here](collectiveidea#339).

* Resolves collectiveidea#475.
@jits
Copy link

jits commented Mar 28, 2019

Hi – is there anything we can do / help with to move this PR forward? Thanks.

@jits
Copy link

jits commented Jul 22, 2019

Hello again – is there anything we can do to move this along?

@JonathanWThom
Copy link
Contributor Author

Hey @jits, I don't think there's anything to be done on my end, it's a matter of the maintainers having the availability to review this. I'm sure they are very busy! I see that you have a particular use case that this is needed for - I wonder if it's possible to apply a monkey patch to an initializer file for this gem to cover that case. Or, if you were really desperate, you could always fork the gem itself and apply this patch. Although I realize that it not at all ideal, as it'll make future updates harder to work with. Just some ideas!

@jits
Copy link

jits commented Jul 22, 2019

@JonathanWThom – thanks for this really useful PR! And appreciate your suggestions – I'll look into a local monkey patch, or a fork, for now.

I recognise that the maintainers are likely very busy – if they do see this, please let us know if there's anything we can do to help get this released.

@danielmorrison danielmorrison merged commit d79451d into collectiveidea:master Sep 6, 2019
@JonathanWThom
Copy link
Contributor Author

Thanks for merging @danielmorrison!

malcolmbaig added a commit to malcolmbaig/audited that referenced this pull request Apr 7, 2021
Stay up to date with the original gem, including support for Rails 6.1
that was added since the fork.

From the changelog:

Added

- Add redacted option
[collectiveidea#485](collectiveidea#485)
- Rails 6.1. support
[collectiveidea#554](collectiveidea#554)
[collectiveidea#559](collectiveidea#559)

Improved

- Avoid extra query on first audit version
[collectiveidea#513](collectiveidea#513)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Idea] Filter option
3 participants