Introduce non_auditable_columns lazy method. #99
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For what it's worth, +1 on this. I unknowingly implemented your patch almost exactly a few days ago, and was about to submit a pull request when I saw yours! |
|
Why this fix isn't applied yet? Can we please have this merged? |
|
Was just about to open a pull request with this exact feature. https://github.com/ankane/audited/commit/6491337edceb3e481a26fcd33df2f664abc38d95 👍 |
|
This has been implemented in newer versions of the gem. |
rocket-turtle
pushed a commit
to rocket-turtle/audited
that referenced
this pull request
Jan 4, 2023
…und_exists add documentation about #exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is adopted version of pull request #78. I do not understand why it was not applied before...
Let me clarify what use case it resolves. When an user of audited creates a model and pass :only option, e.g.
then
rake db:migratewill constantly fail because Audited will callcolumn_nameson a model without table.I am sure this is a typical use case and every user of audited will be frustrated when it will encounter such an error. ;)