New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for deprecations in multi_json 1.3.0 #26
Conversation
After reviewing what Rails is doing about this for the 3.2 branch, I'm not sure the original changes I posted are the most appropriate. I am going to resubmit code that is compatible with the other change. |
The concern I have with doing that is that json_spec 1.0.1 is not going to be compatible with the next rails 3.2 release, whenever that is. That seems like a fairly big breaking change that doesn't belong in a point release. |
Looks like someone changed their mind after that pull request was merged in and allows I'll let @laserlemon decide if he wants to keep the dependency to |
Yeah, that's on the master (4.0) branch though. See the following for 3.2: https://github.com/rails/rails/blob/3-2-stable/activesupport/activesupport.gemspec |
Ah good catch. I thought I was looking at the 3.2 branch. Well that's uncool. I'll bring it up with the MultiJson guys. |
I'm keeping an eye on rails/rails#5896 - if that gets merged in, we will be alright sticking with |
rails/rails#5896 was pulled in to allow I'm thinking changing the gemspec to do |
@laserlemon fixed this as of c2c3780 |
Considering json_spec is a testing gem, I want to make sure its dependencies are as open as they can be. The feature-detection nature of the fix isn't all that pretty but… oh well. Thanks for all the help guys. 👏 |
This cleans up some deprecation warnings when using json_spec with multi_json >= 1.3.0. It feels better to bump the multi_json dependency rather than put in begin/rescue blocks to handle fallback to the older methods if the new code doesn't work, so the gemspec was also updated.