Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total overhaul of several JSON files #848

Merged
merged 4 commits into from
Jul 9, 2019

Conversation

DandelionSprout
Copy link
Contributor

@DandelionSprout DandelionSprout commented Jul 9, 2019

After struggling for the nth time with looking up specific licences in License.json, I decided to try to implement something I've had in mind for the past 6 months, and which indeed turned out to require disproportionately much work to implement:

A total overhaul of License.json and Syntax.json, now with de facto categories and sections to make them much easier to look around in!

@collinbarrett collinbarrett added the directory-data changes to basic FilterLists data label Jul 9, 2019
@collinbarrett
Copy link
Owner

Oof. Wow, I see what you did there.

I like the end result, but it's a big change. Let me ponder it for a bit.

Did you do this all in a text-editor just with copy/paste? How sure are you that it is relatively error-free? Not trying to challenge all your hard work, it's just a big/risky change and I know if I had done this myself I would have made all kinds of mistakes trying to copy/paste and keep everything consistent.

@DandelionSprout
Copy link
Contributor Author

I used Ctrl+H and "Replace All" quite a lot, and I feel that License.json and Syntax.json should be almost entirely error-free, though I can't guarantee it 100%.

Honestly, I'm more worried about SoftwareSyntax.json, where I may or may not have lost count of which numbers I had converted to which.

@collinbarrett
Copy link
Owner

Ok.

Yeah, we need #372, I know...

I'll review it/think on it for a bit.

Thanks!

@collinbarrett collinbarrett merged commit 75e19da into collinbarrett:master Jul 9, 2019
collinbarrett added a commit that referenced this pull request Jul 9, 2019
@collinbarrett
Copy link
Owner

temporarily rolled this back. production server went down and I suspect this to be the cause. I'll investigate more when I get home and have better access to logs.

@collinbarrett
Copy link
Owner

yeah, reverting that fixed the issue. i'll investigate the logs and update over in #849

collinbarrett added a commit that referenced this pull request Jul 10, 2019
collinbarrett added a commit that referenced this pull request Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
directory-data changes to basic FilterLists data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants