Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Fix GUI_ENABLED=OFF and skip SiftGPU if no GUI and no CUDA #2151

Merged
merged 3 commits into from
Sep 10, 2023
Merged

[Bugfix] Fix GUI_ENABLED=OFF and skip SiftGPU if no GUI and no CUDA #2151

merged 3 commits into from
Sep 10, 2023

Conversation

sarlinpe
Copy link
Contributor

@sarlinpe sarlinpe commented Sep 8, 2023

  • Fix broken build when GUI_ENABLED=OFF
    • Exclude colmap_gui
    • Exclude Qt/GL dependencies in colmap_util
  • Faster build when GUI_ENABLED=OFF CUDA_ENABLED=OFF
    • Disable GPU extraction+matching
    • Skip building SiftGPU

@sarlinpe sarlinpe changed the title Disable SiftGPU if no GUI and no CUDA [Bugfix] Fix GUI_ENABLED=OFF and disable SiftGPU if no GUI and no CUDA Sep 8, 2023
@sarlinpe sarlinpe changed the title [Bugfix] Fix GUI_ENABLED=OFF and disable SiftGPU if no GUI and no CUDA [Bugfix] Fix GUI_ENABLED=OFF and skip SiftGPU if no GUI and no CUDA Sep 8, 2023
@ahojnnes ahojnnes enabled auto-merge (squash) September 9, 2023 20:57
@ahojnnes ahojnnes merged commit 3cdceaa into colmap:main Sep 10, 2023
11 checks passed
@sarlinpe sarlinpe deleted the paul/add-gpu-enabled branch September 12, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sarlinpe @ahojnnes