Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align reconstructions via shared 3D points #2169

Merged
merged 26 commits into from
Sep 16, 2023
Merged

Align reconstructions via shared 3D points #2169

merged 26 commits into from
Sep 16, 2023

Conversation

sarlinpe
Copy link
Contributor

@sarlinpe sarlinpe commented Sep 13, 2023 •
edited

Depends on #2147

  • Add Sim3d::EstimateRobust
  • Add AlignReconstructionsViaPoints

@sarlinpe sarlinpe mentioned this pull request Sep 13, 2023
Merged
@sarlinpe sarlinpe marked this pull request as ready for review September 15, 2023 08:57
@sarlinpe
Copy link
Contributor Author

PTAL @ahojnnes

@ahojnnes
Copy link
Contributor

Thanks, LGTM, few minor nit comments.

@ahojnnes ahojnnes closed this Sep 15, 2023
@ahojnnes ahojnnes reopened this Sep 15, 2023
@sarlinpe
Copy link
Contributor Author

PTAL. FYI it looks like feature/colmap_feature_sift_test is flaky and randomly fails. I don't have the permission to re-run the CI when this occurs.

@ahojnnes ahojnnes enabled auto-merge (squash) September 16, 2023 10:55
@ahojnnes ahojnnes merged commit 07f1395 into colmap:main Sep 16, 2023
11 checks passed
@sarlinpe sarlinpe deleted the align-models-points branch February 8, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahojnnes ahojnnes ahojnnes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sarlinpe @ahojnnes @skydes