Stop setting C++ standard flags manually #2251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 717d069 does now enforce C++14 in any case.
borovik135
pushed a commit
to borovik135/colmap
that referenced
this pull request
Nov 6, 2023
Commit 717d069 does now enforce C++14 in any case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 717d069 does now enforce C++14 in any case.
@ahojnnes This is basically a revert of commit 3a2ae37 and commit 2bc8182.
If compilation with compilers not supporting C++14 might still work, removing the
CMAKE_CXX_STANDARD_REQUIREDadded in commit 717d069 would automatically downgrade to the highest C++ version supported by the compiler.