Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow getters FocalLength{X,Y} for isotropic models #2301

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Allow getters FocalLength{X,Y} for isotropic models #2301

merged 3 commits into from
Dec 19, 2023

Conversation

sarlinpe
Copy link
Contributor

@sarlinpe sarlinpe commented Dec 18, 2023 •
edited

Simplify the higher level logic, especially for Python users (colmap/pycolmap#199).

By the way: what is the rationale for using debug checks DCHECK_* instead of CHECK_* in scene/camera.h getters and setters?

ahojnnes
ahojnnes reviewed Dec 18, 2023
View reviewed changes
src/colmap/scene/camera.h Outdated Show resolved Hide resolved
@ahojnnes
Copy link
Contributor

DCHECK has no runtime overhead when compiling in release (non-debug) mode.

@sarlinpe @ahojnnes
Compact condition
2310461 
Co-authored-by: Johannes Schönberger <jsch@demuc.de>
@ahojnnes ahojnnes enabled auto-merge (squash) December 19, 2023 06:11
@ahojnnes ahojnnes merged commit 3c39e6a into colmap:main Dec 19, 2023
11 checks passed
@sarlinpe sarlinpe deleted the sarlinpe/focal-length-xy branch December 19, 2023 10:45
@sarlinpe sarlinpe mentioned this pull request Dec 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahojnnes ahojnnes Awaiting requested review from ahojnnes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sarlinpe @ahojnnes