Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Boost targets and cleanup includes #2304

Merged
merged 5 commits into from
Dec 21, 2023

Conversation

sarlinpe
Copy link
Contributor

No description provided.

@sarlinpe sarlinpe marked this pull request as draft December 19, 2023 17:56
@sarlinpe
Copy link
Contributor Author

vcpkg doesn't export a Boost::headers target microsoft/vcpkg#33282

@ahojnnes
Copy link
Contributor

@sarlinpe The changes look good to me but I see you revered to draft status. Are there any blockers? The CI build on top of vcpkg seems to pass?

@sarlinpe sarlinpe marked this pull request as ready for review December 21, 2023 08:25
@sarlinpe
Copy link
Contributor Author

@ahojnnes I wanted to run some checks first, it's now ready for merge!

@ahojnnes ahojnnes merged commit 9d970e5 into colmap:main Dec 21, 2023
11 checks passed
@sarlinpe sarlinpe deleted the sarlinpe/fix-boost-targets branch February 8, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants