Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing public link deps, break circular feature-scene dependency #2497

Merged
merged 3 commits into from Apr 14, 2024

Conversation

ahojnnes
Copy link
Contributor

@ahojnnes ahojnnes commented Apr 7, 2024

  • Propagates missing public link dependencies that prevent ceres headers from being found.
  • These new dependencies revealed a circular dependency between scene/feature that is broken by a new feature_types library.

@sarlinpe
Copy link
Contributor

sarlinpe commented Apr 7, 2024

  1. Wouldn't it be simpler to merge feature/types.h into util/types.h?
  2. The pycolmap CI is down because liblzma is now down following the vulnerability discovered in xz: [liblzma] port uses compromised version microsoft/vcpkg#37839 Best is to wait that this gets fixed in vcpkg.

@ahojnnes
Copy link
Contributor Author

ahojnnes commented Apr 9, 2024

  1. I would like to avoid shoving more types into the global util/types to avoid a global knot in the dependency graph.
  2. Thanks, I'll make a vcpkg update in a separate PR first.

@sarlinpe
Copy link
Contributor

sarlinpe commented Apr 11, 2024

liblzma is now back online (no need to update VCPKG) but freeimage now fails in all VCPKG-based pipelines.

@ahojnnes ahojnnes enabled auto-merge (squash) April 14, 2024 16:16
@ahojnnes ahojnnes merged commit 7d911b1 into main Apr 14, 2024
15 checks passed
@ahojnnes ahojnnes deleted the user/joschonb/circular-dep-feature-scene branch April 14, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants