Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug crashing VCPKG-based CI builds #2508

Merged
merged 22 commits into from
Apr 13, 2024
Merged

Debug crashing VCPKG-based CI builds #2508

merged 22 commits into from
Apr 13, 2024

Conversation

sarlinpe
Copy link
Contributor

No description provided.

@sarlinpe
Copy link
Contributor Author

sarlinpe commented Apr 11, 2024

@ahojnnes FYI the sample project and all VCPKG-based CI builds are currently broken with CMake 3.29.1 (see microsoft/vcpkg#37968 and there), which is installed on all GitHub runners since yesterday. We should wait that microsoft/vcpkg#38017 gets merged or that the GitHub runners get updated to CMake 3.29.2, which was just released and patches this issue (see actions/runner-images#9680).

@sarlinpe sarlinpe marked this pull request as ready for review April 13, 2024 09:53
@sarlinpe
Copy link
Contributor Author

sarlinpe commented Apr 13, 2024

@ahojnnes This quick fix uses the GitHub action lukka/get-cmake to overwrite the broken CMake that is installed by default on the runners. It also takes care of installing ninja (with caching, so fast). Updating VCPKG is more work than expected so I leave it to a later PR (this commit is a good starter).

@sarlinpe sarlinpe requested a review from ahojnnes April 13, 2024 10:10
@sarlinpe sarlinpe merged commit e258d3a into main Apr 13, 2024
15 checks passed
@sarlinpe sarlinpe deleted the sarlinpe/fix-vcpkg-ci branch April 13, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants