Skip to content

Commit

Permalink
Cleanup includes (#255)
Browse files Browse the repository at this point in the history
  • Loading branch information
sarlinpe committed Jan 26, 2024
1 parent 8693e05 commit fd89f23
Show file tree
Hide file tree
Showing 25 changed files with 5 additions and 79 deletions.
2 changes: 0 additions & 2 deletions pycolmap/estimators/absolute_pose.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// Authors: Mihai-Dusmanu (mihaidusmanu), Paul-Edouard Sarlin (skydes)

#include "colmap/estimators/pose.h"
#include "colmap/geometry/rigid3.h"
#include "colmap/math/random.h"
Expand Down
8 changes: 0 additions & 8 deletions pycolmap/estimators/alignment.h
Original file line number Diff line number Diff line change
@@ -1,15 +1,7 @@
// Author: Philipp Lindenberger (Phil26AT)

#include "colmap/estimators/alignment.h"
#include "colmap/estimators/similarity_transform.h"
#include "colmap/exe/model.h"
#include "colmap/geometry/sim3.h"
#include "colmap/optim/loransac.h"
#include "colmap/scene/reconstruction.h"
#include "colmap/sensor/models.h"
#include "colmap/util/misc.h"
#include "colmap/util/ply.h"
#include "colmap/util/types.h"

#include "pycolmap/log_exceptions.h"

Expand Down
4 changes: 1 addition & 3 deletions pycolmap/estimators/essential_matrix.h
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Authors: Mihai-Dusmanu (mihaidusmanu), Paul-Edouard Sarlin (skydes)

#include "colmap/estimators/essential_matrix.h"
#include "colmap/geometry/essential_matrix.h"
#include "colmap/geometry/pose.h"
#include "colmap/geometry/rigid3.h"
#include "colmap/math/random.h"
#include "colmap/optim/loransac.h"
#include "colmap/scene/camera.h"
Expand Down
2 changes: 0 additions & 2 deletions pycolmap/estimators/fundamental_matrix.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// Authors: Mihai-Dusmanu (mihaidusmanu), Paul-Edouard Sarlin (skydes)

#include "colmap/estimators/fundamental_matrix.h"
#include "colmap/math/random.h"
#include "colmap/optim/loransac.h"
Expand Down
5 changes: 1 addition & 4 deletions pycolmap/estimators/generalized_absolute_pose.h
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
// Authors: Mihai-Dusmanu (mihaidusmanu), Paul-Edouard Sarlin (skydes)

#include "colmap/estimators/generalized_pose.h"
#include "colmap/estimators/pose.h"
#include "colmap/geometry/pose.h"
#include "colmap/geometry/rigid3.h"
#include "colmap/math/random.h"
#include "colmap/optim/ransac.h"
#include "colmap/scene/camera.h"
#include "colmap/util/misc.h"

#include "pycolmap/log_exceptions.h"
#include "pycolmap/utils.h"
Expand Down
2 changes: 0 additions & 2 deletions pycolmap/estimators/homography_matrix.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// Authors: John Lambert (johnwlambert), Paul-Edouard Sarlin (skydes)

#include "colmap/estimators/homography_matrix.h"
#include "colmap/math/random.h"
#include "colmap/optim/loransac.h"
Expand Down
2 changes: 2 additions & 0 deletions pycolmap/estimators/triangulation.h
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
#include "colmap/estimators/triangulation.h"
#include "colmap/scene/camera.h"
#include "colmap/scene/image.h"

#include "pycolmap/helpers.h"
#include "pycolmap/log_exceptions.h"
Expand Down
5 changes: 0 additions & 5 deletions pycolmap/estimators/two_view_geometry.h
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
// Authors: John Lambert (johnwlambert), Paul-Edouard Sarlin (skydes)

#include "colmap/estimators/two_view_geometry.h"
#include "colmap/estimators/utils.h"
#include "colmap/geometry/pose.h"
#include "colmap/math/random.h"
#include "colmap/optim/loransac.h"
#include "colmap/scene/camera.h"
#include "colmap/scene/two_view_geometry.h"

Expand Down
2 changes: 0 additions & 2 deletions pycolmap/geometry/homography_matrix.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// Author: Adi Singh (adisingh50)

#include "colmap/geometry/homography_matrix.h"

#include "pycolmap/log_exceptions.h"
Expand Down
2 changes: 0 additions & 2 deletions pycolmap/helpers.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// Author: Philipp Lindenberger (Phil26AT)

#pragma once

#include "colmap/util/string.h"
Expand Down
2 changes: 0 additions & 2 deletions pycolmap/log_exceptions.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// Author: Philipp Lindenberger (Phil26AT)

#pragma once
#include "colmap/util/misc.h"

Expand Down
6 changes: 0 additions & 6 deletions pycolmap/pipeline/extract_features.h
Original file line number Diff line number Diff line change
@@ -1,14 +1,8 @@
// Author: Philipp Lindenberger (Phil26AT)

#include "colmap/controllers/feature_extraction.h"
#include "colmap/controllers/feature_matching.h"
#include "colmap/controllers/image_reader.h"
#include "colmap/controllers/incremental_mapper.h"
#include "colmap/exe/feature.h"
#include "colmap/exe/sfm.h"
#include "colmap/feature/sift.h"
#include "colmap/scene/reconstruction.h"
#include "colmap/sensor/models.h"
#include "colmap/util/misc.h"

#include "pycolmap/helpers.h"
Expand Down
8 changes: 1 addition & 7 deletions pycolmap/pipeline/images.h
Original file line number Diff line number Diff line change
@@ -1,15 +1,9 @@
// Author: Paul-Edouard Sarlin (skydes)

#include "colmap/controllers/feature_extraction.h"
#include "colmap/controllers/feature_matching.h"
#include "colmap/controllers/image_reader.h"
#include "colmap/controllers/incremental_mapper.h"
#include "colmap/exe/feature.h"
#include "colmap/exe/sfm.h"
#include "colmap/feature/sift.h"
#include "colmap/image/undistortion.h"
#include "colmap/scene/camera.h"
#include "colmap/scene/reconstruction.h"
#include "colmap/sensor/models.h"
#include "colmap/util/misc.h"

#include "pycolmap/helpers.h"
Expand Down
6 changes: 0 additions & 6 deletions pycolmap/pipeline/match_features.h
Original file line number Diff line number Diff line change
@@ -1,14 +1,8 @@
// Author: Philipp Lindenberger (Phil26AT)

#include "colmap/controllers/feature_extraction.h"
#include "colmap/controllers/feature_matching.h"
#include "colmap/controllers/image_reader.h"
#include "colmap/controllers/incremental_mapper.h"
#include "colmap/estimators/two_view_geometry.h"
#include "colmap/exe/feature.h"
#include "colmap/exe/sfm.h"
#include "colmap/feature/sift.h"
#include "colmap/util/misc.h"

#include "pycolmap/helpers.h"
#include "pycolmap/log_exceptions.h"
Expand Down
1 change: 0 additions & 1 deletion pycolmap/pipeline/meshing.h
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// Author: Philipp Lindenberger (Phil26AT)
#include "colmap/mvs/meshing.h"

#include "pycolmap/helpers.h"
Expand Down
10 changes: 0 additions & 10 deletions pycolmap/pipeline/mvs.h
Original file line number Diff line number Diff line change
@@ -1,14 +1,5 @@
#include "colmap/controllers/feature_extraction.h"
#include "colmap/controllers/feature_matching.h"
#include "colmap/controllers/image_reader.h"
#include "colmap/controllers/incremental_mapper.h"
#include "colmap/exe/feature.h"
#include "colmap/exe/sfm.h"
#include "colmap/feature/sift.h"
#include "colmap/mvs/fusion.h"
#include "colmap/mvs/meshing.h"
#include "colmap/scene/reconstruction.h"
#include "colmap/sensor/models.h"
#include "colmap/util/misc.h"

#ifdef COLMAP_CUDA_ENABLED
Expand Down Expand Up @@ -249,7 +240,6 @@ void BindMVS(py::module& m) {
.def_readwrite("bounding_box",
&SFOpts::bounding_box,
"Bounding box Tuple[min, max]");

MakeDataclass(PyStereoFusionOptions);
auto stereo_fusion_options = PyStereoFusionOptions().cast<SFOpts>();

Expand Down
1 change: 0 additions & 1 deletion pycolmap/pipeline/sfm.h
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// Author: Paul-Edouard Sarlin (skydes)
#include "colmap/controllers/bundle_adjustment.h"
#include "colmap/controllers/incremental_mapper.h"
#include "colmap/exe/sfm.h"
Expand Down
2 changes: 0 additions & 2 deletions pycolmap/scene/camera.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// Author: Philipp Lindenberger (Phil26AT)

#include "colmap/scene/camera.h"
#include "colmap/sensor/models.h"
#include "colmap/util/misc.h"
Expand Down
2 changes: 0 additions & 2 deletions pycolmap/scene/correspondence_graph.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// Author: Mihai Dusmanu (mihaidusmanu)

#include "colmap/feature/types.h"
#include "colmap/scene/correspondence_graph.h"
#include "colmap/util/types.h"
Expand Down
2 changes: 0 additions & 2 deletions pycolmap/scene/image.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// Author: Philipp Lindenberger (Phil26AT)

#include "colmap/geometry/rigid3.h"
#include "colmap/scene/image.h"
#include "colmap/util/misc.h"
Expand Down
3 changes: 0 additions & 3 deletions pycolmap/scene/point2D.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
// Author: Philipp Lindenberger (Phil26AT)

// Use Eigens aligned allocator for vectors
#include "colmap/scene/point2d.h"
#include "colmap/util/misc.h"
#include "colmap/util/types.h"
Expand Down
2 changes: 0 additions & 2 deletions pycolmap/scene/point3D.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// Author: Philipp Lindenberger (Phil26AT)

#include "colmap/scene/point3d.h"
#include "colmap/util/misc.h"
#include "colmap/util/types.h"
Expand Down
1 change: 0 additions & 1 deletion pycolmap/scene/reconstruction.h
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// Author: Philipp Lindenberger (Phil26AT)
#include "colmap/scene/reconstruction.h"
#include "colmap/sensor/models.h"
#include "colmap/util/misc.h"
Expand Down
2 changes: 0 additions & 2 deletions pycolmap/scene/track.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// Author: Philipp Lindenberger (Phil26AT)

#include "colmap/scene/track.h"
#include "colmap/util/misc.h"
#include "colmap/util/types.h"
Expand Down
2 changes: 0 additions & 2 deletions pycolmap/sfm/incremental_triangulator.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// Author: Mihai Dusmanu (mihaidusmanu)

#include "colmap/sfm/incremental_triangulator.h"

#include "pycolmap/helpers.h"
Expand Down

0 comments on commit fd89f23

Please sign in to comment.