Added Pybind Wrapper for COLMAP's Homography Decomposition Function #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| namespace py = pybind11; | ||
|
|
||
| py::dict homography_decomposition_estimation ( |
There was a problem hiding this comment.
looks great @adisingh50. Maybe you could add a docstring here too explaining each of the inputs, and maybe explain that the points should be normalized beforehand?
sarlinpe
pushed a commit
that referenced
this pull request
Jan 5, 2022
Added Pybind Wrapper for COLMAP's Homography Decomposition Function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a pybind wrapper over COLMAP's homography decomposition function:
PoseFromHomographyMatrix()(source code here). Named the python module:homography_decomposition().@johnwlambert and I are experimenting with it in our gtsfm project to accurately decompose relative rotation and unit translations from a pair we suspect to be a homography.