Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[types] Remove module augmentation (v0.6) #567

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

MysteryBlokHed
Copy link
Member

This is essentially the same change as #566, but for the main branch instead of a patch for v0.5.

I don't think there should be anything missing here—I re-copied and pasted the augmentation contents from index.d.ts to color.d.ts to make sure I didn't miss any new properties—but review has been requested just in case :)

This is essentially the same change as #566, but for the main branch
instead of a patch for v0.5.
Copy link

netlify bot commented Jun 27, 2024

Deploy Preview for colorjs failed. Why did it fail? →

Name Link
🔨 Latest commit 16328cf
🔍 Latest deploy log https://app.netlify.com/sites/colorjs/deploys/667cbb7e6b59ee000846e6c7

@MysteryBlokHed MysteryBlokHed changed the title [types] Remove module augmentation [types] Remove module augmentation (v0.6) Jun 27, 2024
@lloydk
Copy link
Collaborator

lloydk commented Jun 27, 2024

LGTM

I tested it with #569 and all the type tests passed.

Copy link
Member

@jgerigmeyer jgerigmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These specific changes look good, but it looks like since #564 was merged, the entire build process is failing because of errors in the tsc step. Even combining this with #569 doesn't help, so it's difficult for me to test. What am I missing?

@lloydk
Copy link
Collaborator

lloydk commented Jun 27, 2024 via email

@MysteryBlokHed
Copy link
Member Author

tsc is probably reporting type errors from the actual logic of the code. That should probably actually be fixed within the code, but in the meantime, is there some way to force it to exit with code 0? Just so we can actually get the build to run.

@lloydk
Copy link
Collaborator

lloydk commented Jun 27, 2024

tsc is probably reporting type errors from the actual logic of the code. That should probably actually be fixed within the code, but in the meantime, is there some way to force it to exit with code 0? Just so we can actually get the build to run.

I created #571 that should allow the build to run.

@MysteryBlokHed
Copy link
Member Author

I'll try merging this and the other active typing PR's and see what the situation is like then

@MysteryBlokHed MysteryBlokHed merged commit 0661f89 into main Jun 27, 2024
0 of 5 checks passed
@MysteryBlokHed MysteryBlokHed deleted the types/remove-color-augmentation-v0.6 branch June 27, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants