Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add activation modal w/ current status ✅ #430

Merged

Conversation

tomas-salgado
Copy link
Collaborator

Description ✏️

Closes #219

This PR implements a modal on the home page that helps clarify how and if member can claim swag pack.

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@tomas-salgado
Copy link
Collaborator Author

Screenshot 2024-08-02 at 2 15 22 PM

For now I added a button to the modal within the Merch Shop card. Perhaps it's fine to have it here or maybe elsewhere. Will discuss with Rami at next sync up.
Also need to discuss what messages we want to have for each of the 3 cases

@tomas-salgado tomas-salgado marked this pull request as draft August 8, 2024 21:17
Copy link
Member

@ramiAbdou ramiAbdou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomas-salgado Made a few updates so that this modal incorporates the activation checklist, as well as a description + FAQs for each item. Hopefully this will help ease any confusion w/ how to knock off an item!

https://www.loom.com/share/7dc0e665a94144c997a8216f5aaf51f7?sid=8f2e81a2-52c9-4214-8aa1-bd93883c96b4

@ramiAbdou ramiAbdou changed the title feat: add swag pack eligibility modal feat: add activation modal w/ current status ✅ Aug 20, 2024
@ramiAbdou ramiAbdou marked this pull request as ready for review August 20, 2024 21:24
@ramiAbdou ramiAbdou merged commit 5aa88c5 into colorstackorg:main Aug 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "swag pack eligibility" page 📆
2 participants