Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve resource search to include description 🔎 #466

Merged
merged 1 commit into from
Aug 23, 2024
Merged

feat: improve resource search to include description 🔎 #466

merged 1 commit into from
Aug 23, 2024

Conversation

gpolite0
Copy link
Contributor

Description ✏️

Closes #464

  • the search term will now check the title and the description of the resources
  • screenshot below shows the feature working properly
Screenshot 2024-08-22 at 8 04 13 PM

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@gpolite0 gpolite0 changed the title add description to list-resources query feat: improve search logic to include description Aug 23, 2024
ramiAbdou
ramiAbdou approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@ramiAbdou ramiAbdou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks @gpolite0! 🚀

@ramiAbdou ramiAbdou changed the title feat: improve search logic to include description feat: improve resource search logic to include description 🔎 Aug 23, 2024
@ramiAbdou ramiAbdou changed the title feat: improve resource search logic to include description 🔎 feat: improve resource search to include description 🔎 Aug 23, 2024
@ramiAbdou ramiAbdou merged commit d0faab8 into colorstackorg:main Aug 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramiAbdou ramiAbdou ramiAbdou approved these changes

Assignees

@gpolite0 gpolite0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: improve search logic to include description 🔎
2 participants
@gpolite0 @ramiAbdou